Skip to content

Update version in deployment - #57

Open
kusumachalasani wants to merge 1 commit into
kruize:mvp_demofrom
kusumachalasani:version_change
Open

kusumachalasani wants to merge 1 commit into
kruize:mvp_demofrom
kusumachalasani:version_change

Conversation

@kusumachalasani

@kusumachalasani kusumachalasani commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Summary by Sourcery

Deployment:

  • Update the deployment to use the 0.0.2 Kruize optimizer image.

Signed-off-by: kusuma chalasani <kchalasani@ibm.com>
@kusumachalasani kusumachalasani self-assigned this Nov 9, 2026
@sourcery-ai

sourcery-ai Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Reviewer's Guide

Configuration

Update the deployed kruize-optimizer image from version 0.0.1 to 0.0.2.

  • deployment/base/deployment.yaml L21

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 2 issues

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="deployment/base/deployment.yaml" line_range="21" />
<code_context>
         - name: kruize-optimizer
           # TODO: This image will be updated with kruize org image
-          image: quay.io/kruize/kruize-optimizer:0.0.1
+          image: quay.io/kruize/kruize-optimizer:0.0.2
           imagePullPolicy: Always
           ports:
</code_context>
<issue_to_address>
**Optimizer image cannot be pulled**

When the documented build flow is used without separately publishing tag `0.0.2` at `quay.io/kruize/kruize-optimizer`, kubernetes cannot pull the image requested by the deployment: the documented build publishes to `quay.io/kruize/optimizer`, while CI checks `quay.io/kruizehub/optimizer` without pushing. The pod stays unavailable and the updated version is not deployed.

Make the deployment image reference match the image that the build and publish flow pushes, or publish the image to the deployment’s repository.
</issue_to_address>

### Comment 2
<location path="deployment/base/deployment.yaml" line_range="21" />
<code_context>
         - name: kruize-optimizer
           # TODO: This image will be updated with kruize org image
-          image: quay.io/kruize/kruize-optimizer:0.0.1
+          image: quay.io/kruize/kruize-optimizer:0.0.2
           imagePullPolicy: Always
           ports:
</code_context>
<issue_to_address>
**Rollout duplicates scheduled jobs**

When an enabled bulk config exists while Kubernetes rolls out the updated image, the old and new pods each initialize timers for the same enabled configs and submit the same bulk jobs to Kruize, so a version rollout can create duplicate experiments.

Ensure only one pod schedules jobs at a time, for example with leader election or a rollout strategy that stops the old pod before starting the new one.
</issue_to_address>

Sourcery assessment

Approval pending. 2 findings to address first.

Blocking findings: deployment/base/deployment.yaml:21, deployment/base/deployment.yaml:21


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

- name: kruize-optimizer
# TODO: This image will be updated with kruize org image
image: quay.io/kruize/kruize-optimizer:0.0.1
image: quay.io/kruize/kruize-optimizer:0.0.2

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 High · Optimizer image cannot be pulled

When the documented build flow is used without separately publishing tag 0.0.2 at quay.io/kruize/kruize-optimizer, kubernetes cannot pull the image requested by the deployment: the documented build publishes to quay.io/kruize/optimizer, while CI checks quay.io/kruizehub/optimizer without pushing. The pod stays unavailable and the updated version is not deployed.

Make the deployment image reference match the image that the build and publish flow pushes, or publish the image to the deployment’s repository.

Prompt for AI agents
In `deployment/base/deployment.yaml` at line 21:

**Optimizer image cannot be pulled**

When the documented build flow is used without separately publishing tag `0.0.2` at `quay.io/kruize/kruize-optimizer`, kubernetes cannot pull the image requested by the deployment: the documented build publishes to `quay.io/kruize/optimizer`, while CI checks `quay.io/kruizehub/optimizer` without pushing. The pod stays unavailable and the updated version is not deployed.

Make the deployment image reference match the image that the build and publish flow pushes, or publish the image to the deployment’s repository.

- name: kruize-optimizer
# TODO: This image will be updated with kruize org image
image: quay.io/kruize/kruize-optimizer:0.0.1
image: quay.io/kruize/kruize-optimizer:0.0.2

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium · Rollout duplicates scheduled jobs

When an enabled bulk config exists while Kubernetes rolls out the updated image, the old and new pods each initialize timers for the same enabled configs and submit the same bulk jobs to Kruize, so a version rollout can create duplicate experiments.

Ensure only one pod schedules jobs at a time, for example with leader election or a rollout strategy that stops the old pod before starting the new one.

Prompt for AI agents
In `deployment/base/deployment.yaml` at line 21:

**Rollout duplicates scheduled jobs**

When an enabled bulk config exists while Kubernetes rolls out the updated image, the old and new pods each initialize timers for the same enabled configs and submit the same bulk jobs to Kruize, so a version rollout can create duplicate experiments.

Ensure only one pod schedules jobs at a time, for example with leader election or a rollout strategy that stops the old pod before starting the new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant